bin/75258: [patch] dd(1) has not async signal safe interrupt
Oleg V. Nauman
oleg at reis.zp.ua
Sun Dec 19 07:30:25 PST 2004
The following reply was made to PR bin/75258; it has been noted by GNATS.
From: "Oleg V. Nauman" <oleg at reis.zp.ua>
To: Maxim Konovalov <maxim at macomnet.ru>
Cc: bug-followup at freebsd.org
Subject: Re: bin/75258: [patch] dd(1) has not async signal safe interrupt handlers
Date: Sun, 19 Dec 2004 17:29:59 +0200
Content-Type: text/plain; charset=koi8-r
On Sun, Dec 19, 2004 at 06:11:06PM +0300, Maxim Konovalov wrote:
> > >Description:
> > dd(1) uses not safe interrupt handlers, they may leads to
> > strange problems with dd
> Are you sure? Do you have a testcase?
> > >How-To-Repeat:
> > man 2 sigaction
> Well, stdio(3) is not signal-safe in general but it seems for me
> summary() does not manipulate with the internal state of any file
> descriptors (it uses write(2)) and should be safe.
But s*printf() family uses malloc(3) for his internal purposes,
and there is no any reasons for things like memory allocations in
the signal handler, I think.
> Browseing the commit history says the same.
> > +int need_summary;
> This should be volatile sig_atomic_to.
Yes, you are right, thank you.
> Maxim Konovalov
-----BEGIN PGP SIGNATURE-----
Version: PGP 6.5.8
-----END PGP SIGNATURE-----
More information about the freebsd-bugs