kern/70611: MBR type no longer visible in GEOM dumps

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Aug 18 01:30:39 PDT 2004


The following reply was made to PR kern/70611; it has been noted by GNATS.

From: "Poul-Henning Kamp" <phk at phk.freebsd.dk>
To: Michiel Boland <Michiel.Boland at internl.net>
Cc: FreeBSD-gnats-submit at freebsd.org
Subject: Re: kern/70611: MBR type no longer visible in GEOM dumps 
Date: Wed, 18 Aug 2004 10:25:23 +0200

 In message <200408180819.i7I8J6CP002734 at brakkenstein.nijmegen.internl.net>, Mic
 hiel Boland writes:
 
 >>Number:         70611
 >>Category:       kern
 >>Synopsis:       MBR type no longer visible in GEOM dumps
 
 >>How-To-Repeat:
 >Type sysctl -b kern.geom.dumptxt
 >The ouput contains lines like the following:
 >
 >1 MBR ad0s1 39999504384 512 i 0 o 32256
 >
 >The line above should have a ' ty ' entry appended.
 
 Can you try this patch:
 
 Index: geom_slice.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/geom/geom_slice.c,v
 retrieving revision 1.55
 diff -u -r1.55 geom_slice.c
 --- geom_slice.c	25 Jul 2004 09:41:31 -0000	1.55
 +++ geom_slice.c	18 Aug 2004 08:24:47 -0000
 @@ -465,7 +465,8 @@
  	gp->softc = gsp;
  	gp->start = g_slice_start;
  	gp->spoiled = g_slice_spoiled;
 -	gp->dumpconf = g_slice_dumpconf;
 +	if (gp->dumpconf == NULL)
 +		gp->dumpconf = g_slice_dumpconf;
  	if (gp->class->destroy_geom == NULL)
  		gp->class->destroy_geom = g_slice_destroy_geom;
  	cp = g_new_consumer(gp);
 
 -- 
 Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
 phk at FreeBSD.ORG         | TCP/IP since RFC 956
 FreeBSD committer       | BSD since 4.3-tahoe    
 Never attribute to malice what can adequately be explained by incompetence.


More information about the freebsd-bugs mailing list