misc/65212: running startx hangs the system

[Bruce Evans]

On Fri, 9 Apr 2004, Kris Kennaway wrote:

> On Sat, Apr 10, 2004 at 01:33:47PM +1000, Bruce Evans wrote:
> > On Fri, 9 Apr 2004, Kris Kennaway wrote:
> > > Were you using any modules?  They need to be recompiled for SMP.
> >
> > Er, modules shouldn't depend on any options.  None in the tree changed
> > when I tested rebuilding them with -DSMP.
>
> Maybe this changed at some point recently, but it used to be the case
> (and still is on 4.x?).

This hasn't changed for at least 5 years.  An example of the the support
for modules being independent of SMP:

% RCS file: /home/ncvs/src/sys/i386/include/atomic.h,v
% Working file: atomic.h
% head: 1.32
% ...
% ----------------------------
% revision 1.3
% date: 1999/07/13 06:35:25;  author: alc;  state: Exp;  lines: +58 -38
% Commit the correct patch, i.e., the one that actually corresponds
% to the rev 1.2 log entry.
% ----------------------------
% revision 1.2
% date: 1999/07/13 03:32:17;  author: alc;  state: Exp;  lines: +42 -22
% Changed the implementation of the primitives to guarantee atomicity
% with respect to interrupts on UP systems.  (The upgrade from gcc 2.7.x
% to egcs 1.1.2 produced at least one non-atomic code sequence in
% swap_pager_getpages.)
%
% In addition, the primitives are now SMP-safe, but only on SMPs.  (For
                                                                   ^^^^
% portability between SMPs and UPs, modules are compiled with the SMP-safe
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

% versions.)
  ^^^^^^^^^^
%
% Submitted by:	dillon and myself
% Reviewed by:	bde
% ----------------------------

Bruce