kern/47920: if ng_pppoe switches to nonstandard mode it stays
in it forever
Yar Tikhiy
yar at FreeBSD.ORG
Tue Dec 9 05:20:04 PST 2003
The following reply was made to PR kern/47920; it has been noted by GNATS.
From: Yar Tikhiy <yar at FreeBSD.ORG>
To: Gleb Smirnoff <glebius at cell.sick.ru>,
FreeBSD-gnats-submit at FreeBSD.ORG, freebsd-bugs at FreeBSD.ORG
Cc:
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Tue, 9 Dec 2003 16:14:41 +0300
I would rather change the name of the variable "nonstandard"
to "pppoe_mode", not "standard", because lines like this one:
standard = PPPOE_NONSTANDARD;
give me a schizoid feeling :-)
I also believe you should not omit the "freebsd-gnats-submit at freebsd.org"
address from the list of recipients when sending a follow-up to a PR, or
else GNATS will not be able to add your follow-up to the audit trail.
--
Yar
More information about the freebsd-bugs
mailing list