kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever

Yar Tikhiy yar at FreeBSD.ORG
Tue Dec 9 05:15:19 PST 2003


I would rather change the name of the variable "nonstandard"
to "pppoe_mode", not "standard", because lines like this one:

	standard = PPPOE_NONSTANDARD;

give me a schizoid feeling :-)

I also believe you should not omit the "freebsd-gnats-submit at freebsd.org"
address from the list of recipients when sending a follow-up to a PR, or
else GNATS will not be able to add your follow-up to the audit trail.

-- 
Yar


More information about the freebsd-bugs mailing list