bin/54854: cvs pserver sig11 crash on 4.8-R
Ruslan Ermilov
ru at FreeBSD.org
Wed Aug 13 08:40:14 PDT 2003
The following reply was made to PR bin/54854; it has been noted by GNATS.
From: Ruslan Ermilov <ru at FreeBSD.org>
To: Scott Mitchell <scott+freebsd at fishballoon.org>
Cc: bug-followup at FreeBSD.org
Subject: Re: bin/54854: cvs pserver sig11 crash on 4.8-R
Date: Wed, 13 Aug 2003 18:31:23 +0300
On Wed, Aug 13, 2003 at 02:00:35AM -0700, Scott Mitchell wrote:
>
> Still seeing these crashes with a stock cvs 1.11.6 (ie. without any of the
> FreeBSD extension). The stack traces are very similar - it's interesting
> to note that the crash seems to be triggered by bad cleanup from a SIGPIPE,
> which I guess is related to the client-server connection closing down...
>
> Anyway, it looks less likely that this is a FreeBSD problem, although I
> still don't have any kind of solution other than using the binary from 4.6.
> We're planning to swap out the RAM in this machine within the next couple
> of weeks and run all the memory tests again, plus try all the versions of
> cvs we've built, in case this changes anything.
>
See if this patch helps.
%%%
Index: contrib/cvs/src/server.c
===================================================================
RCS file: /home/ncvs/src/contrib/cvs/src/server.c,v
retrieving revision 1.13.2.5
diff -u -p -r1.13.2.5 server.c
--- contrib/cvs/src/server.c 21 Jan 2003 22:26:46 -0000 1.13.2.5
+++ contrib/cvs/src/server.c 4 Mar 2003 16:47:06 -0000
@@ -4889,11 +4889,14 @@ server_cleanup (sig)
* have generated any final output, we shut down BUF_TO_NET.
*/
- status = buf_shutdown (buf_from_net);
- if (status != 0)
- error (0, status, "shutting down buffer from client");
- buf_free (buf_from_net);
- buf_from_net = NULL;
+ if (buf_from_net != NULL)
+ {
+ status = buf_shutdown (buf_from_net);
+ if (status != 0)
+ error (0, status, "shutting down buffer from client");
+ buf_free (buf_from_net);
+ buf_from_net = NULL;
+ }
}
if (dont_delete_temp)
%%%
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru at sunbay.com Sunbay Software Ltd,
ru at FreeBSD.org FreeBSD committer
More information about the freebsd-bugs
mailing list