misc/44148: installworld in 4.7-STABLE does not install
IPFilter related header files
ru at freebsd.org
Fri Apr 25 07:14:21 PDT 2003
On Fri, Apr 25, 2003 at 10:43:22PM +1000, Bruce Evans wrote:
> On Fri, 25 Apr 2003, Ruslan Ermilov wrote:
> > On Fri, Apr 25, 2003 at 03:54:32PM +1000, Darren Reed wrote:
> > > In some email I received from Ruslan Ermilov, sie wrote:
> > >
> > > Checking application/pgp-signature: FAILURE
> > > -- Start of PGP signed section.
> > > > On Fri, Apr 25, 2003 at 04:18:45AM +1000, Darren Reed wrote:
> > > > > In some email I received from Ruslan Ermilov, sie wrote:
> > > > > > In the SHARED=symlinks case, /usr/include/netinet is
> > > > > > the symlink to /usr/src/sys/netinet. Hope this now
> > > > > > makes more sense.
> > > > >
> > > > > Is there any reason to not create a real /usr/include/netinet
> > > > > and then populate _that_ directory with symbolic links to each
> > > > > of the files, individually ? This should preserve the semantics
> > > > > of what "symlinks" is about.
> Much as I dislike symlink farms, I think this would work OK (the same
> as symlinks from individual headers in the top level of /usr/include to
> various places in the src tree).
> > > > We could create /usr/include/contrib/ipfilter/netinet, and
> > > > that will be consistent with kern.pre.mk. Those that need
> > > > it would just add -I/usr/include/contrib/ipfilter. How is
> > > > this?
> Doesn't seem any better.
My worries are about the case when someone deletes or adds an
include file. If we keep symlinks on a per-directory level,
there's no problem. But if we switch to per-header symlinks,
each time the new header is added, or old header is removed,
you'll have to re-run "make install" in src/include/. Other
than that, I'd like to keep the consistency in how the kernel
build does this, and how this does the userland. Currently,
kern.pre.mk has -I$S/contrib/ipfilter, and if we add the
-I/usr/include/contrib/ipfilter, this would work as well.
So, I'd like to either do this on a directory level, or kill
the SHARED=symlinks concept.
Please let me know what do you think before I go for implementing
one or another.
Ruslan Ermilov Sysadmin and DBA,
ru at sunbay.com Sunbay Software AG,
ru at FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-bugs/attachments/20030425/944a28c0/attachment.bin
More information about the freebsd-bugs