bin/51151: du hardlinkmatching is slow - fix included
Peter van Dijk
peter at dataloss.nl
Sun Apr 20 02:20:16 PDT 2003
The following reply was made to PR bin/51151; it has been noted by GNATS.
From: Peter van Dijk <peter at dataloss.nl>
To: David Schultz <das at FreeBSD.ORG>
Cc: FreeBSD-gnats-submit at FreeBSD.ORG
Subject: Re: bin/51151: du hardlinkmatching is slow - fix included
Date: Sun, 20 Apr 2003 11:18:35 +0200
On Sun, Apr 20, 2003 at 01:27:24AM -0700, David Schultz wrote:
> A hash table would be more appropriate here. You could even
> preserve the original behavior of making infrequent calls to
> malloc() and most of the original code by using open addressing.
Yup, I'd prefer a hash too, but libc doesn't provide a suitable one,
so I figured giving this a shot was a viable option :)
> In any case, pulling in another library is probably not desirable.
I feared as much.
> If you would like to revise this patch, I would be happy to help
> you get it committed. You might also want to take a look at
I indeed care about this patch (or at least, a patch that speeds up
du) getting committed.
I glanced over style(9) before I submitted the patch - any specific
nits with the current patch, regarding style?
[resent with gnats in Cc:]
peter at dataloss.nl | ~ we care a lot: about the war we're fighting
www.dataloss.nl | - gee that looks like fun! (Faith no more)
| iraqbodycount.net: min 1878, max 2325
More information about the freebsd-bugs