misc/50945: BUG: NOINSTALLLIB isn't honored in all Makefiles

[Rene de Vries]

>Number:         50945
>Category:       misc
>Synopsis:       BUG: NOINSTALLLIB isn't honored in all Makefiles
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 14 07:20:13 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Rene de Vries/Edwin H. Kremer
>Release:        FreeBSD 4.7-RELEASE-p3 i386/FreeBSD 5.0-20030401 i386
>Organization:
Tunix OSC BV, Nijmegen
>Environment:
	FreeBSD 4.7-RELEASE-p3 and FreeBSD 5.0-CURRENT-20030401
>Description:
	Libraries don't need to be installed for a binary only
	installation. For the most part of FreeBSD this works using
	the NOINSTALLLIB define (during build and install), but for 
	the makefiles mentioned below this doesn't work properly.
>How-To-Repeat:
>Fix:

Files:
	gnu/lib/csu/Makefile
	lib/csu/i386/Makefile
	lib/csu/i386-elf/Makefile
	lib/libncurses/Makefile

Diffed against FreeBSD 5.0 (as of 20030401):

Index: gnu/lib/csu/Makefile
===================================================================
RCS file: /home/fbsd-cvsrepo/src/gnu/lib/csu/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- gnu/lib/csu/Makefile	27 Feb 2003 09:19:31 -0000	1.16
+++ gnu/lib/csu/Makefile	1 Apr 2003 12:36:18 -0000
@@ -60,9 +60,11 @@
 	${MAKE} -f ${.ALLSRC} MFILE=${.ALLSRC} GCCDIR=${GCCDIR} ${.TARGET}
 
 realinstall:
+.if !defined(NOINSTALLLIB)
 .for file in ${OBJS} ${SOBJS} ${TGTOBJS}
 	${INSTALL} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
 	    ${file} ${DESTDIR}${LIBDIR}/${file:S/.So$/S.o/}
 .endfor
+.endif
 
 .include <bsd.lib.mk>
Index: lib/csu/i386/Makefile
===================================================================
RCS file: /home/fbsd-cvsrepo/src/lib/csu/i386/Makefile,v
retrieving revision 1.42
diff -u -r1.42 Makefile
--- lib/csu/i386/Makefile	29 Jul 2002 09:40:10 -0000	1.42
+++ lib/csu/i386/Makefile	1 Apr 2003 12:36:18 -0000
@@ -41,8 +41,10 @@
 	@mv ${.TARGET}.tmp ${.TARGET}
 
 realinstall:
+.if !defined(NOINSTALLLIB)
 	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 444 ${OBJS} \
 		${DESTDIR}${LIBDIR}
+.endif
 
 depend:	.depend
 
Index: lib/csu/i386-elf/Makefile
===================================================================
RCS file: /home/fbsd-cvsrepo/src/lib/csu/i386-elf/Makefile,v
retrieving revision 1.17
diff -u -r1.17 Makefile
--- lib/csu/i386-elf/Makefile	29 Jul 2002 09:40:11 -0000	1.17
+++ lib/csu/i386-elf/Makefile	1 Apr 2003 12:36:18 -0000
@@ -18,7 +18,9 @@
 	${CC} ${CFLAGS} -DGCRT -c -o gcrt1.o ${.CURDIR}/crt1.c
 
 realinstall:
+.if !defined(NOINSTALLLIB)
 	${INSTALL} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
 	    ${OBJS} ${DESTDIR}${LIBDIR}
+.endif
 
 .include <bsd.lib.mk>
Index: lib/libncurses/Makefile
===================================================================
RCS file: /home/fbsd-cvsrepo/src/lib/libncurses/Makefile,v
retrieving revision 1.66
diff -u -r1.66 Makefile
--- lib/libncurses/Makefile	25 Feb 2003 15:41:49 -0000	1.66
+++ lib/libncurses/Makefile	1 Apr 2003 12:36:18 -0000
@@ -230,11 +230,13 @@
 	make_keys MKterm.h.awk comp_captab.c curses.head \
 	namehdr nameftr codeftr ${NAMESRC} ${CODESRC}
 
+.if !defined(NOINSTALLLIB)
 SYMLINKS+=libncurses.a ${LIBDIR}/libcurses.a
 SYMLINKS+=libncurses.a ${LIBDIR}/libtermcap.a
 SYMLINKS+=libncurses.a ${LIBDIR}/libtermlib.a
 SYMLINKS+=libncurses.a ${LIBDIR}/libmytinfo.a
 SYMLINKS+=libncurses.a ${LIBDIR}/libtinfo.a
+.endif
 .if !defined(NOPIC)
 # no need for major at all, it's an ld-time redirection only
 SYMLINKS+=libncurses.so ${SHLIBDIR}/libcurses.so



>Release-Note:
>Audit-Trail:
>Unformatted: