obexapp should not use libbsdxml

Iain Hibbert plunky at rya-online.net
Wed Nov 3 10:28:25 UTC 2010


Hi,

according to the libbsdxml manpage,

 http://www.freebsd.org/cgi/man.cgi?query=libbsdxml&apropos=0&sektion=0&manpath=FreeBSD+8.1-RELEASE&format=html

it should not really be used by external programs.. using expat directly
(as per patch below) will cut down on a patch that is required on NetBSD

+ expat dependency would need to be added in ports/comms/obexapp
  (I guess that translating expat to builtin bsdxml could feature
   automatically in ports framework using ln -s)

iain

--- Makefile.orig	2010-01-08 18:31:22.000000000 +0000
+++ Makefile	2010-11-03 10:11:34.000000000 +0000
@@ -16,9 +16,9 @@
 CFLAGS+=	-I/usr/local/include \
 		-I/usr/local/include/openobex

-DPADD=		${LIBBLUETOOTH} ${LIBSDP} ${LIBBSDXML} ${LIBREADLINE}
+DPADD=		${LIBBLUETOOTH} ${LIBSDP} ${LIBREADLINE}
 LDADD=		-L/usr/lib -L/usr/local/lib \
-		-lbluetooth -lsdp -lopenobex -lbsdxml -lreadline -liconv
+		-lbluetooth -lsdp -lopenobex -lexpat -lreadline -liconv

 .include <bsd.prog.mk>

--- util.c.orig	2010-10-22 07:29:06.000000000 +0100
+++ util.c	2010-01-08 19:51:02.000000000 +0000
@@ -30,9 +30,9 @@
  */

 #include <bluetooth.h>
-#include <bsdxml.h>
 #include <ctype.h>
 #include <errno.h>
+#include <expat.h>
 #include <iconv.h>
 #include <langinfo.h>
 #include <libgen.h>


More information about the freebsd-bluetooth mailing list