obexapp patches for type-punning

Maksim Yevmenkin maksim.yevmenkin at gmail.com
Tue Dec 1 23:25:56 UTC 2009

On Tue, Dec 1, 2009 at 11:31 AM, Iain Hibbert <plunky at rya-online.net> wrote:
> Hi,
> while on the subject of obexapp, I have a patch to remove some annoying
> 'type punning' compilation errors that gcc spits out that I'm not totally
> sure are valid, but see below anyway..

that is why i had -fno-strict-aliasing in makefile :)

> I don't understand the OBEX protocol or libopenobex enough to know if it
> is possible, but the last case also removes a potential NULL dereference -
> if the OBEX_ObjectGetNonHdrData() fails to recover a proper data, an error
> is logged but it carries on and hdr->flags might cause a segfault?

yes, i think those are good. combined patch went out in the previous email.


More information about the freebsd-bluetooth mailing list