svn commit: r455173 - in head: multimedia/ffmpeg multimedia/libass net/asterisk13 net/freerdp x11/rxvt-unicode

Jan Beich jbeich at FreeBSD.org
Thu Nov 30 08:14:31 UTC 2017


Michal Meloun <melounmichal at gmail.com> writes:

> On 30.11.2017 8:35, Jan Beich wrote:
>> Mark Linimon <linimon at FreeBSD.org> writes:
>> 
>>> Author: linimon
>>> Date: Thu Nov 30 07:02:49 2017
>>> New Revision: 455173
>>> URL: https://svnweb.freebsd.org/changeset/ports/455173
>>>
>>> Log:
>>>   For ports that set particular flags/options for armv6, also set them
>>>   for armv7.
>> [...]
>>> Modified: head/multimedia/ffmpeg/Makefile
>>> ==============================================================================
>>> --- head/multimedia/ffmpeg/Makefile	Thu Nov 30 07:01:14 2017	(r455172)
>>> +++ head/multimedia/ffmpeg/Makefile	Thu Nov 30 07:02:49 2017	(r455173)
>>> @@ -54,6 +54,7 @@ OPTIONS_GROUP_LICENSE=	GPL3 NONFREE
>>>  
>>>  OPTIONS_DEFINE_amd64=	MMX SSE
>>>  OPTIONS_DEFINE_armv6=	VFP NEON
>>> +OPTIONS_DEFINE_armv7=	VFP NEON
>> 
>> Are you sure about disabling VFP and NEON by default? If so bump PORTREVISION.
>> Otherwise, back this part out.
>> 
> It's not enabling instead of disabling ?

ffmpeg detects VFP and NEON during configure. By exposing the options
without adding to defaults the port appends --disable-vfp --disable-neon.

Build logs:
- r455173 (this commit):  http://sprunge.us/JjKT
- r455176 (back out):     http://sprunge.us/SUKJ

>>> +CONFIGURE_ARGS_armv7=		--disable-fast-unaligned
>> 
>> Can anyone on arm@ list confirm bug 200609 affects armv7 as well?
>> I'd prefer to avoid the pessimization otherwise.
>> 
> We supports unaligned access for armv6 starting from r300701 so yes,
> it's supported for armv7 from beginning.

Mark, can you back this part out as well?


More information about the freebsd-arm mailing list