[Bug 211087] sys/arm/ti/cpsw/if_cpsw.c:1937: bad expression ?

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211087

            Bug ID: 211087
           Summary: sys/arm/ti/cpsw/if_cpsw.c:1937: bad expression ?
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: arm
          Assignee: freebsd-arm at FreeBSD.org
          Reporter: dcb314 at hotmail.com

sys/arm/ti/cpsw/if_cpsw.c:1937]: (style) Expression '(X & 0x8800) == 0x4800' is
always false.

Source code is

        if ((flags & (CPDMA_BD_SOP | CPDMA_BD_TDOWNCMPLT)) ==
            (CPDMA_BD_EOP | CPDMA_BD_TDOWNCMPLT)) {

Maybe better code

        if ((flags & (CPDMA_BD_SOP | CPDMA_BD_TDOWNCMPLT)) ==
            (CPDMA_BD_SOP | CPDMA_BD_TDOWNCMPLT)) {

-- 
You are receiving this mail because:
You are the assignee for the bug.