[Differential] [Commented On] D2377: Introduce ARM GICv3 support
zbb (Zbigniew Bodek)
phabric-noreply at FreeBSD.org
Wed May 13 15:19:49 UTC 2015
zbb added inline comments.
INLINE COMMENTS
sys/arm64/arm64/gic_v3.c:321 DELAY is because we if fact expect to get immediate response from GIC. If we don't get any this most probably means malfunction. I would suggest to wait that second and panic instead of device_printf(). I don't have any good explanation why 1 second and not for example 0.5. There are no timing details in the GIC documentation related to that and the one below so this value was based on what Linux code does.
REVISION DETAIL
https://reviews.freebsd.org/D2377
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: zbb, ian, emaste, andrew, imp, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm
More information about the freebsd-arm
mailing list