[Differential] [Commented On] D2377: Introduce ARM GICv3 support

[ian (Ian Lepore)]

ian added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:163 and why does everybody write function calls through pointers in that style?  It's not required by style(9).  IMO, the write way to spell that call would be
  
    err = init_func(sc);
  
  sys/arm64/include/armreg.h:113 Eeek!  No way -- the registers should be sorted ascending by address, not by name, so that they match the way they're documented.  (I've yet to see a soc manual arrange register docs alphabetical as opposed to by address.)

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm