[Differential] [Accepted] D2357: Port x86 busdma to ARM64

andrew (Andrew Turner) phabric-noreply at FreeBSD.org
Thu May 7 16:17:17 UTC 2015


andrew accepted this revision.
andrew added a comment.
This revision has a positive review.

Only a few minor issues.


INLINE COMMENTS
  sys/arm64/arm64/busdma_bounce.c:202 Wouldn't error already be zero in this case?
  sys/arm64/arm64/busdma_bounce.c:323 Extra braces
  sys/arm64/arm64/busdma_machdep.c:127 Could you provide a better error string here?
  sys/arm64/arm64/busdma_machdep.c:133 We only return a NULL tag on some failures? There is a case on the previous line where it could fail without the tag set.
  sys/arm64/include/bus_dma_impl.h:32 There should be no tab after `#ifndef`

REVISION DETAIL
  https://reviews.freebsd.org/D2357

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew
Cc: onwahe-gmail-com, emaste, freebsd-arm


More information about the freebsd-arm mailing list