[Differential] [Commented On] D2005: Start of arm64 toolchain support (sufficient for kernel-toolchain)

[imp (Warner Losh)]

imp added a comment.

Not quite ready for prime time, and adds extra warts to the build system that don't need to be added to it.

INLINE COMMENTS
  Makefile.inc1:325 This is ugly. Why is aarch64 special? Why wouldn't we need it for sparc64 if we removed ld and gcc? I really don't like this at all.
  
   I know it is here for convenience, but there's got to be a more generic way to do it.
  share/mk/bsd.endian.mk:6 This shouldn't reference MACHINE. I should fix that.
  share/mk/src.opts.mk:233-238 This is wrong on a number of levels.
  
  We generally opt-out of binaries in the .mk files.
  It allows people to set them to 'yes' even though it can't possibly work.
  
  We really need an "__ALWAYS_NO" which could be set based on what
  arch you are on. I can add that. binuitls might be that specail.
  
  gdb certainly isn't.

REVISION DETAIL
  https://reviews.freebsd.org/D2005

To: emaste, bdrewery
Cc: imp, andrew, freebsd-arm