[Differential] [Updated] D2701: Add options to dmb() and dsb() macros

andrew (Andrew Turner) phabric-noreply at FreeBSD.org
Tue Jun 2 09:18:17 UTC 2015


andrew added a comment.

Given you are changing these can you also mark them as with `ish*`?


INLINE COMMENTS
  sys/arm64/arm64/db_interface.c:164-165 Are these needed? The cache handling functions already have dsb and isb instructions.
  sys/arm64/include/atomic.h:32 This should be `#define<tab>isb()...`
  sys/arm64/include/atomic.h:49-54 And these

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D2701

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, imp, ian, andrew
Cc: emaste, andrew, imp, freebsd-arm


More information about the freebsd-arm mailing list