"No valid device tree blob found" error

[Luiz Otavio O Souza]

On 16 February 2014 18:30, Glen Barber <gjb at freebsd.org> wrote:
> Images for RPI-B and BEAGLEBONE (and I suspect PANDABOARD) are failing
> to boot this week.
>
> The images are built against r261948.  Console messages during boot:
>
>   ## Starting application at 0x88000054 ...
>   Consoles: U-Boot console
>   Compatible API signature found @9f242240
>   MMC Device 2 not found
>   MMC Device 3 not found
>   Number of U-Boot devices: 2
>
>   FreeBSD/armv6 U-Boot loader, Revision 1.2
>   (root at grind.freebsd.org, Sun Feb 16 18:10:43 UTC 2014)
>   DRAM:    512MB
>
>   Device: disk
>   Loading /boot/defaults/loader.conf
>   /boot/kernel/kernel data=0x460bc8+0x2c7438
>   syms=[0x4+0x85a60+0x4+0x50c89]
>
>   Hit [Enter] to boot immediately, or any other key for command prompt.
>   Booting [/boot/kernel/kernel]...
>   Using DTB provided by U-Boot.
>   No valid device tree blob found!WARNING! Trying to fire up the kernel,
>   but no device tree blob found!
>
> Any ideas if this is error on my part, or a problem in head/ ?  The
> stable/10/ images boot fine, so I do not suspect any code changes in the
> build process.
>


Glen,

I think it is related to r261819. Looking at the code it looks like
the attached patch may fix it (i'm still updating my images to the
latest -head and would probably need a few hours before i can test it
myself).

Can you check if it works for you ?

Thanks,

Luiz
-------------- next part --------------
Index: head/sys/boot/fdt/fdt_loader_cmd.c
===================================================================
--- head/sys/boot/fdt/fdt_loader_cmd.c	(revision 262036)
+++ head/sys/boot/fdt/fdt_loader_cmd.c	(working copy)
@@ -230,7 +230,7 @@
 	int err;
 
 	fdtp_size = fdt_totalsize(header);
-	err = fdt_check_header(&header);
+	err = fdt_check_header(header);
 	if (err < 0) {
 		sprintf(command_errbuf, "error validating blob: %s",
 		    fdt_strerror(err));