Problem running make_dtb.sh

[Michael Tuexen]

On 31 Aug 2014, at 00:40, Ian Lepore <ian at FreeBSD.org> wrote:

> On Fri, 2014-08-29 at 20:45 +0200, Michael Tuexen wrote:
>> On 29 Aug 2014, at 15:58, Ian Lepore <ian at FreeBSD.org> wrote:
>> 
>>> On Fri, 2014-08-29 at 14:44 +0200, Michael Tuexen wrote:
>>>> Dear all,
>>>> 
>>>> when trying to build the kernel on a Wandboard the traditional way as described in
>>>> https://www.freebsd.org/doc/en/books/developers-handbook/kernelbuild.html#kernelbuild-traditional
>>>> a make results in
>>>> ...
>>>> sh ../../../tools/fdt/make_dtb.sh ../../.. wandboard-quad.dts /usr/home/tuexen/sys/arm/compile/WANDBOARD-QUAD
>>>> converting wandboard-quad.dts -> /usr/home/tuexen/sys/arm/compile/WANDBOARD-QUAD/wandboard-quad.dtb
>>>> <built-in>:159:10: fatal error: 'wandboard-quad.dts' file not found
>>>> #include "wandboard-quad.dts"
>>>>        ^
>>>> 1 error generated.
>>>> Error: <stdin>:1.1-2.1 syntax error
>>>> FATAL ERROR: Unable to parse input tree
>>>> *** Error code 1
>>>> 
>>>> Stop.
>>>> 
>>>> The reason is that make_dtb.sh uses $MACHINE which is not set. If I set it to arm, the make completes
>>>> successfully. How is this fixed in the best way?
>>>> 
>>>> Best regards
>>>> Michael
>>> 
>>> IMO, the best way to fix it would be to update the handbook to say that
>>> the "traditional" way of building a kernel is no longer supported.
>>> Since that won't fly due to a small but very vocal minority, maybe the
>>> attached patch would be a good fix.
>>> 
>>> -- Ian
>>> 
>>> Index: sys/tools/fdt/make_dtb.sh
>>> ===================================================================
>>> --- sys/tools/fdt/make_dtb.sh	(revision 270064)
>>> +++ sys/tools/fdt/make_dtb.sh	(working copy)
>>> @@ -12,6 +12,10 @@ if [ -z "$dts" ]; then
>>>    exit 1
>>> fi
>>> 
>>> +if [ -z "${MACHINE}" ]; then
>>> +    MACHINE=$(uname -m)
>>> +fi
>>> +
>>> for d in ${dts}; do
>>>    dtb=${dtb_path}/`basename $d .dts`.dtb
>>>    echo "converting $d -> $dtb"
>> That resolves the issue. Will you commit it?
> 
> Done, r270863.
Thanks.

Michael
> 
> -- Ian
> 
> 
>