New PV entry allocator for pmap-v6.c

[Aleksandr Rybalko]

On Wed, 08 May 2013 10:59:01 +0200
Zbyszek Bodek <zbb at semihalf.com> wrote:

> On 04.05.2013 19:30, Zbyszek Bodek wrote:
> > Hello everyone,
> >
> > As a part of Semihalf work on Superpages support,
> > we've made some pmap-v6.c improvements and clean-ups.
> >
> > We would like to start integrating our code to the mainline FreeBSD,
> > therefore I'm happy to introduce the new PV entry allocator for
> > pmap-v6.c ported from amd64/i386/mips.
> >
> > Alan Cox (alc) was so kind to review the code.
> >
> > If there are no objections, then we will commit this patch to the HEAD
> > around Monday/Tuesday.
> >
> > Please check out the attachment for details.
> >
> 
> Hello again,
> 
> Does anyone have any comments and/or remarks regarding the mentioned patch?
> 
> I was testing it on the multicore ARMv7 machine however, it would be 
> good if someone test it on available ARMv6/ARMv7 platforms.
> 
> Best regards
> Zbyszek Bodek
> 
> 
> _______________________________________________
> freebsd-arm at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arm
> To unsubscribe, send any mail to "freebsd-arm-unsubscribe at freebsd.org"

Hi Zbyszek!

I've not done deep review, but fail to compile it on fresh head:

cc -c -O -pipe -march=armv6 -DARM_ARCH_6=1 -std=c99 -g -Wall
-Wredundant-decls - Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winli ne -Wcast-qual  -Wundef
-Wno-pointer-sign -fformat-extensions  -Wmissing-include -dirs
-fdiagnostics-show-option  -Wno-error-tautological-compare
-Wno-error-empt y-body  -Wno-error-parentheses-equality -nostdinc  -I.
-I/usr/home/ray/work/Free BSD/CLEAN/head/sys
-I/usr/home/ray/work/FreeBSD/CLEAN/head/sys/contrib/altq -I/u
sr/home/ray/work/FreeBSD/CLEAN/head/sys/contrib/libfdt -D_KERNEL
-DHAVE_KERNEL_O PTION_HEADERS -include opt_global.h  -ffreestanding
-Werror  /usr/home/ray/work$
FreeBSD/CLEAN/head/sys/arm/arm/pmap-v6.c /usr/home/ray/work/FreeBSD/CLEAN/head/sys/arm/arm/pmap-v6.c:908:9:

error: no member named 'pvh_attrs' in 'struct md_page' pg->md.pvh_attrs
&= ~(maskbits & (PVF_MOD | PVF_REF)); ~~~~~~^
/usr/home/ray/work/FreeBSD/CLEAN/head/sys/arm/arm/pmap-v6.c:1001:9:

error: no member named 'pvh_attrs' in 'struct md_page' pg->md.pvh_attrs
|= flags & (PVF_REF | PVF_MOD); ~~~~~~ ^

18 errors total.

Thanks a lot!

P.S. how far from full ARM SMP support Semihalf now?

WBW
-- 
Aleksandr Rybalko <ray at freebsd.org>