[PATCH] Add stack unwind support for the functions in .ko

[Andrew Turner]

On Sun, 22 Dec 2013 19:22:39 +0800
Howard Su <howard0su at gmail.com> wrote:

> On Sunday, December 22, 2013, Andrew Turner wrote:
> 
> > On Sun, 22 Dec 2013 17:50:31 +0800
> > Howard Su <howard0su at gmail.com <javascript:;>> wrote:
> >
> > > here is the new version which address the print registers out
> > > problem.
> >
> > There are a number of style bugs in this patch: make sure you limit
> > lines to 80 characters; indentation should use tabs, followed by 4
> > spaces if you need to split a long line; braces should be at the
> > end of a line when used with an if, for or while statement.
> >
> Sure. I will fix style(9) issues.
> 
> >
> > You've added the A0 register. I don't see where it is defined by
> > ARM as a register name or synonym. It is also used to adjust which
> > bit from a bitmask we check. This would mean we read the wrong bit
> > and may get a register that was never updated. Because of this we
> > will never read r0.
> >
> Let me find a better name for this macro. What I want is the macro
> describe the register contains first parameter.

You shouldn't need one, the first parameter is in r0.

Andrew