OpenRD-Client/Ultimate support

Norikatsu Shigemura nork at FreeBSD.org
Sun Jun 20 15:26:43 UTC 2010


Hi mav.

On Sun, 20 Jun 2010 16:31:24 +0300
Alexander Motin <mav at FreeBSD.org> wrote:
> > 	mvs(4):
> > 	5. FDT-ish
> If I understand right, with FDT SOC part of mvs(4) driver is no longer
> need to be named "sata" to attach to the bus. If possible, I would
> prefer it to be renamed to "mvs", same as PCI one.

	like following?

mvs.c
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+       if (!ofw_bus_is_compatible(dev, "mvs"))
+               return (ENXIO);
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

openrd-cl.dts
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
	sata at 80000 {
		compatible = "mrvl,sata", "mvs";
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

	or

openrd-cl.dts
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
	sata at 80000 {
		compatible = "mrvl,sata";
		device_type = "sata";
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

	I'll try device_type = "sata" on sata at 80000.

> Also some not very related cosmetic for the bus: wouldn't it be nice to
> export device "compatible" string to newbus as "pnpinfo" and something
> (may be section name) as "location" string?

	I don't know FDT description style.
	Rafal, how about do you think?

-- 
Norikatsu Shigemura <nork at FreeBSD.org>


More information about the freebsd-arm mailing list