ARM interrupts fixes

[Stanislav Sedov]

On Thu, 04 Sep 2008 15:40:03 +0200
Rafal Jaworowski <raj at semihalf.com> mentioned:

> Hi,
> Please review the following changes around interrupts handling in ARM. We
> already started discussing these items with Olivier some time ago:
> 
> 1. http://people.freebsd.org/~raj/patches/arm/intr-fixes.diff
> 
> At the moment nexus_setup_intr() attempts to set up a number of IRQs in one
> take, calling arm_setup_irqhandler() in loop. This is bogus, as there's just
> one cookie given from the caller and it is overwritten in each iteration so
> that only the last handler's cookie value prevails...
> 
> This patch removes such behaviour, however there's one [mis]user of the old
> approach  i.e. the IXP425 qmgr, which needs adjustments too, see p.2.
> 
> Apart from style fixes, another problem which is corrected in this patch is
> the unmasking the IRQ source in the PIC after the last handler has been
> removed from list.
> 

The patch looks goot to me. But what about splitting the whitespace
fixes and the meaningful ones when committing to the tree to not
pollute the history?

-- 
Stanislav Sedov
ST4096-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-arm/attachments/20080904/1483cb01/attachment.pgp