ARM pmap_enter_pv question

Olivier Houchard mlfbsd at ci0.org
Thu Dec 6 14:07:38 PST 2007


On Thu, Dec 06, 2007 at 03:58:21PM -0600, Mark Tinguely wrote:
> 
> in pmap_enter_pv(), it seems to me there is an "else" missing:
> 
> 	if (pm == pmap_kernel()) {
> 		if (flags & PVF_WRITE)
> 			pg->md.krw_mappings++;
> 		else
> 			pg->md.kro_mappings++;
> 	}					<<<< is there a "else" missing?
> 	if (flags & PVF_WRITE)
> 		pg->md.urw_mappings++;
> 	else
> 		pg->md.uro_mappings++;
> 
> I don't think it will effect any caching settings.
> 

You're right, I wonder where this else went, it must have been there, 
because this code comes from NetBSD, and NetBSD has it.

Thanks a lot !

Olivier


More information about the freebsd-arm mailing list