ARM arch subdir cleanups
M. Warner Losh
imp at bsdimp.com
Sun Dec 2 06:51:16 PST 2007
In message: <4752C2A0.9010604 at semihalf.com>
Rafal Jaworowski <raj at semihalf.com> writes:
: M. Warner Losh wrote:
: > :
: > : I just committed your patches. Yes, this kind of work is very welcome.
: >
: > Indeed. I've done some work trying to get obio abstracted out across
: > all architectures.
: >
:
: Are your OBIO cleanups available somewhere? Are you going to finish these (so
: as not to overlap the work...)?
What I've done to date is available in the p4 branch "arm-devel" and
are in the form of a set of routines in subr_obio.c. They likely need
to be enhanced and generalized a little (I just converted at91 to use
them, nothing else). I had hoped to be able to come up with something
that could also be merged into RELENG_7 as an optional feature to keep
maintenance costs down for things MFC'd.
: > The other thing that I'd like to see is a better defined board/cpu
: > initialization sequence. Or to make better use of the one that's
: > defined now and document it better. I made some bad choices, in
: > hindsight, for the at91rm9200 port that are only now becoming
: > apparent.
: >
:
: Yes, this is a valid point. As we already talked I keep this in mind while
: fleshing out the Orion port, but it'll make more sense for me to return to
: such refactoring in a second spin, after we have basic functionality in operation.
One thing that might help is better documentation in this area. Had
my professional life not taken an unexpected turn recently, I had
planned on getting some time to document the conventions and try to
move all the arm subports into compliance with that vision. I was
then hoping to use that experience to define a cleanup, etc. However,
since I'm going to have a different focus professionally for a while,
I'm afraid I'll have to leave at least some of the heavy lifting on
this to others. My focus will be more MIPS and PowerPC based, but
there's a lot of overlap here.
Warner
More information about the freebsd-arm
mailing list