ARM arch subdir cleanups
Olivier Houchard
mlfbsd at ci0.org
Sun Dec 2 05:13:38 PST 2007
On Fri, Nov 30, 2007 at 12:53:35PM +0100, Rafal Jaworowski wrote:
> Hi,
> Attached are two patches with the following cleanups:
>
> 1. Convert nexus to standard device since it's mandatory anyway, remove stale
> nexus_io_asm.S and nexus_io.c
>
> 2. Streamline sys/conf/files.arm (and hence the kernel image contents): move
> asm routines to appropriate sys/arm/<platform>/files.<platform>
>
>
> It seems to me other items in the ARM arch subdirectory would benefit from
> optimization/cleanups too, for example:
>
> - Shared OBIO routines. At least these are nearly identical and could be
> compressed into one I guess:
>
> xscale/i80321/obio_space.c
> xscale/i8134x/obio_space.c
> xscale/pxa2x0/pxa2x0_space.c (in P4)
>
> - Shared bus space generic methods. A lot of BS methods like *_bs_map(),
> _bs_subregion() etc. are copied in separate files for different ARM platforms,
> but most of this could be placed in one file, just like we have a common
> assembly routines in the arm/arm/bus_space_asm_generic.S.
>
> - Others like arm/arm/machdep.c and arm/arm/sys_machdep.c seem akin, could
> they be merged into one file?
>
> I can work on cleaning those up, would such changes be welcome?
>
> Rafal
Hi Rafal,
I just committed your patches. Yes, this kind of work is very welcome.
Thanks a lot !
Olivier
More information about the freebsd-arm
mailing list