[patch] unprivileged mlock(2)
Andriy Gapon
avg at FreeBSD.org
Wed Sep 5 06:33:07 UTC 2012
on 04/09/2012 20:48 Andrey Zonov said the following:
> On 9/4/12 9:10 PM, Andriy Gapon wrote:
>> on 30/08/2012 13:58 Andrey Zonov said the following:
[snip]
>>> [2] http://people.freebsd.org/~zont/racct.patch
>>
>> This patch looks correct.
>>
>
> There is no need for this patch as I mentioned earlier. racct_set()
> doesn't add any additional locking here.
I thought that hiding the racct call behind RACCT was a worthy target on its own.
>> And it also makes me wonder why kern/kern_racct.c is marked as standard while
>> all(?) uses of racct API are placed under RACCT option.
>
> Not all. I think some code was not easy to put under RACCT.
But perhaps it should still have been a goal for this optional feature.
Unfortunately, Edward hasn't replied yet.
>> Ditto for kern_rctl.c/RCTL.
>> I think that excluding these file if the options are not used would help to catch
>> cases where the API is used unconditionally and it would also help to reduce
>> kernel sizes a tiny bit too.
--
Andriy Gapon
More information about the freebsd-arch
mailing list