unix domain sockets on nullfs(5)

[Konstantin Belousov]

On Sun, Feb 19, 2012 at 11:55:20AM +0200, Mikolaj Golub wrote:
> 
> On Sat, 18 Feb 2012 23:50:03 +0200 Konstantin Belousov wrote:
> 
>  KB> On Sat, Feb 18, 2012 at 11:22:03PM +0200, Mikolaj Golub wrote:
>  >> After collecting all suggestions and additional testing I have got this patch
>  >> set:
>  >> 
>  >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.1.patch
>  KB> Including unpcb.h into vfs_subr.c looks too extreme. Put the prototype
>  KB> into vnode.h, possibly renaming the function to vfs_unp_reclaim.
> 
> Done.
> 
>  >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch
>  >> http://people.freebsd.org/~trociny/VOP_UNP.3.patch
>  KB> I has a painting suggestion there, call the vops VOP_UNP_DETACH etc,
>  KB> otherwise it takes too much reading to understand that it is not undetach.
> 
> Unfortunately, vnode_if.awk does not support underscores in VOP names. It
> failed with "Invalid %% construction" due to the restriction: $2 !~ /^[a-z]+$/.
> So I reverted back to the old naming.
Ok, might be it makes sense to try to add underscore to the set of
allowed symbols.

> 
> The updated patches:
> 
> http://people.freebsd.org/~trociny/unp_prepare_reclaim.2.patch
> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch
> http://people.freebsd.org/~trociny/VOP_UNP.4.patch

In the comment above vfs_unp_reclaim(), say "before socket-type vnode
reclamation".

I have no further comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20120219/dcc32f9f/attachment.pgp