Is there any reason not to remove all the spl() calls in rtsock.c?

Ryan Stone rysto32 at gmail.com
Tue Apr 26 02:39:12 UTC 2011


On Mon, Apr 25, 2011 at 9:59 PM, George Neville-Neil
<gnn at neville-neil.com> wrote:
> Howdy,
>
> I was just reviewing the code in rtsock.c, specifically rts_attach().  Is there any reason
> not to just remove the spl* calls?  I don't see anything obvious that needs protection
> that is not now protected by a finer grained lock.
>
> Best,
> George

The spl* calls have been no-ops for over 10 years now(since r71240),
so I certainly hope that there's nothing requiring their protection.

It's probably long-past time to kill off those stubs, I'd imagine.


More information about the freebsd-arch mailing list