newbus: type (max value) for device order

Andriy Gapon avg at freebsd.org
Fri Sep 3 07:56:16 UTC 2010


device_add_child_ordered() takes order as a parameter of int type.
struct device stores it as u_char.

This can be confusing, can't it?
In fact, up to r203776 we used to use order value of 100000 in acpi.c (which
effectively was 160 according to my calculations).

Not sure what I want to suggest, perhaps defining DEVICE_MAX_ORDER or something.
Or changing the type in struct device to int.

-- 
Andriy Gapon


More information about the freebsd-arch mailing list