[PATCH] Headers for the x86 subtree

John Baldwin jhb at freebsd.org
Thu Oct 28 16:50:09 UTC 2010


On Thursday, October 28, 2010 11:58:25 am Warner Losh wrote:
>   On 10/28/2010 08:53, TAKAHASHI Yoshihiro wrote:
> > In article<201010281013.03261.jhb at freebsd.org>
> > John Baldwin<jhb at freebsd.org>  writes:
> >
> >> I'm still doing testing, but this seems to be working so far.  I am
> >> moving mca.h as my current test.
> > sys/conf/kmod.mk requires the same change of sys/conf/kern.post.mk.
> I think that the pre-patch kern.post.mk code actually may be wrong...  
> Or not so much wrong as redundant with what config(8) already does.  
> IIRC, it was put in there as a stop-gap compatibility thing and it can 
> now actually be removed (although it makes things nicer for John's patch).

Err, I'd rather remove the code from config?  config can't handle the kmod.mk 
and include/Makefile cases and it is easier to verify the logic is identical 
for the three cases if all three are done in Makefiles rather than having two 
of them done via Makefiles and one done via config.

Honestly, I also prefer that we do kernel build stuff in the Makefiles rather 
than config when possible since config is much more of a black box.  Putting 
things in config is also a bit more fragile.

-- 
John Baldwin


More information about the freebsd-arch mailing list