Need a code review

[Oleksandr Tymoshenko]

Dag-Erling Smørgrav wrote:
> Oleksandr Tymoshenko <gonzo at freebsd.org> writes:
>> Here is new fix: http://people.freebsd.org/~gonzo/mips2/libpam2.diff
>> The idea is to set define explicitly for dynamic case rather then rely
>> on __PIC__.
> 
> This is completely backwards.  Dynamic is the default option, and in
> fact the only supported option on many (non-FreeBSD) systems.  If it
> were up to me, I would remove support for statically linked modules
> entirely.
     OK, so the static case is the one to be marked explicitly. Here is
the next patch: http://people.freebsd.org/~gonzo/mips2/libpam3.diff
Drop NO_STATIC_MODULES since it's a default and add PAM_STATIC_MODULES
to request static modules build.

-- 
gonzo