Need a code review

[Oleksandr Tymoshenko]

Oleksandr Tymoshenko wrote:
> Dag-Erling Smørgrav wrote:
>> "M. Warner Losh" <imp at bsdimp.com> writes:
>>> http://people.freebsd.org/~gonzo/mips2/libpam.diff
>>
>> This won't work.  Your patch unconditionally sets NO_STATIC_MODULES
>> which will result in a non-functional libpam.a (the modules will be
>> built into the library, but without any of the glue that allows the
>> library to find them) not just on mips, but on all other platforms.
> 
> openpam detects static modules build using cpp(1) condition:
> #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES)
> The problem is that gcc MIPS option -mabi-calls assumes -fpic for both
> static and dynamic builds. So the question is: would defining
> NO_STATIC_MODULES for MIPS be enough or it should be addressed
> upstream?
     And diff in question is *completely* wrong. NO_STATIC_MODULES should
be added to flags when compiling objects for shlib, not to PICFLAGS
Actual "fix" passed unnoticed by me in contrib/openpam, sorry for misguiding.

-- 
gonzo