sched_lock && thread_lock()
Alan Cox
alc at cs.rice.edu
Thu May 24 13:26:06 UTC 2007
Attilio Rao wrote:
> Attilio Rao wrote:
>
>> Bruce Evans wrote:
>>
>>> 4 more translation errors breaking 8 counters altogether (v_vnodepgsin
>>> is broken twice):
>>
>>
>> Thanks a lot for the revision, there will be a pending patch in the
>> next hour.
>
>
> Hello,
> Let me know if this patch is right for you and if you have feedbacks,
> comments, etc:
> http://users.gufi.org/~rookie/works/patches/schedlock/vmmeter3.diff
>
> This should fix translation errors Bruce has found and switching the
> _SET() method in order to being a simple assignment (as Bruce has
> suggested).
Let me offer a simple rule of thumb for VMCNT_ADD() vs. PCPU_LAZY_INC():
If the field is NOT under the section labeled "Distribution of page
usages." in vmmeter, then PCPU_LAZY_INC() is preferable to VMCNT_ADD()
implemented with an atomic op.
Alan
More information about the freebsd-arch
mailing list