Updated rusage patch
Attilio Rao
attilio at freebsd.org
Fri Jun 8 17:55:01 UTC 2007
2007/6/8, Attilio Rao <attilio at freebsd.org>:
> 2007/6/7, Jeff Roberson <jroberson at chesapeake.net>:
> > The patch at http://people.freebsd.org/~jeff/rusage3.diff fixes points 1
> > and 2 as well as the p_runtime iniitialization problem. This moves the
> > collection of child rusage back into exit1() and changes the exiting
> > threads to accumulate their rusage into p_ru under protection of the
> > process spinlock. This also removes the gross lock/unlock of proc slock
> > (formerly sched_lock) from wait and implements something more sensible.
>
> I have a question:
> it is fair to assume that extra per-proc spinlock
> acquisitions/removals on the PRS_ZOMBIE state are orthogonal to this
> problem? They should belong to another 'fix', shouldn't?
Mm, now I see that you could protect nicely PRS_ZOMBIE through
PROC_LOCK since p_state is marked (j/c), no?
(it is alredy acquired when checking for it).
Attilio
--
Peace can only be achieved by understanding - A. Einstein
More information about the freebsd-arch
mailing list