Removing NET_NEEDS_GIANT: first patch

John Baldwin jhb at freebsd.org
Tue Jul 24 19:36:18 UTC 2007


On Tuesday 24 July 2007 02:21:09 pm Robert Watson wrote:
> 
> On Tue, 24 Jul 2007, John Baldwin wrote:
> 
> > On Tuesday 24 July 2007 06:17:45 am Robert Watson wrote:
> >> Patch attached, and also available at this URL:
> >
> > Possibly use mtx_assert() rather than KASSERT(mtx_owned()) in 
> > nfs_syscalls.c?
> 
> Sounds good, I will make that change.  I picked that new structure because 
it 
> most closely matched what was there, and what was there required a KASSERT 
> because it combined a variable check with a lock check, but the new code 
> doesn't require that.

*nod*  I'd figured as much.  I'd of almost prefer that the previous code had 
been:

	if (!debug_mpsafenet)
		mtx_assert(...)

FWIW.

-- 
John Baldwin


More information about the freebsd-arch mailing list