Fw: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c

[Scott Long]

Peter Jeremy wrote:
> On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote:
> 
>>This is the first commit of many to do what the comment says.
> 
> ...
> 
>> Log:
>> Remove leading __ from __(inline|const|signed|volatile).  They are
>> obsolete.  This should reduce diffs to NetBSD as well.
> 
> 
> K&R function definitions are even more obsolete but still used
> throughout the kernel.  IMHO, potential diff-reduction to NetBSD
> seems a fairly flimsy reason for a significant amount of churn.
> 
> Also, any diff reduction with NetBSD is probably outweighed by
> the diff increase with other FreeBSD branches.
> 
> Maybe this should be treated like whitespace cleanup - something to
> do if you're going to be doing something non-trivial in the source
> file.  (There are probably other cleanups in the same category).
> 

Yeah, diff increase with other FreeBSD branches is a big deal.  While
sharing between RELENG_4 and more recent branches is pretty hard these
days, a lot can be shared between RELENG_5, RELENG_6, and HEAD.

Scott