review: patch to restore VLAN kernel API in RELENG_6

[Xin LI]

On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote:
> On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
> X> > +++ sys/dev/bge/if_bge.c	13 Jan 2006 17:04:31 -0000
> X> > @@ -2862,7 +2862,7 @@
> X> >  		 * attach that information to the packet.
> X> >  		 */
> X> >  		if (have_tag) {
> X> > -			VLAN_INPUT_TAG(ifp, m, vlan_tag);
> X> > +			VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
> X> 
> X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
> X> 
> X> Just my $0.02, though :-)
> 
> I really don't care. :)

Heh, my point was to make it possible to use the same name in
both drivers on RELENG_6 and 7.0, without having to call future
macros "foo_NEW_NG" or so =-)  Not really sure whether it is
conform to our tradition naming, though...

Cheers,