drop snd_ from DRIVER_MODULEs...

John-Mark Gurney gurney_j at resnet.uoregon.edu
Wed Apr 19 08:27:21 UTC 2006


Alexander Leidinger wrote this message on Wed, Apr 19, 2006 at 09:49 +0200:
> Quoting John-Mark Gurney <gurney_j at resnet.uoregon.edu> (from Mon, 17  
> Apr 2006 20:25:20 -0700):
> 
> >Well, I noticed that we have a few extra snd_'s in front of most (all?)
> 
> If it's not in front of all drivers for sound chips (!= all modules  
> which make up the sound system), it's an inconsistency which should be  
> fixed.
> 
> >of our sound drives.. I believe this used to be necessary due to lack of
> >kldxref which couldn't find modules w/ different names than the modules..
> >Now that this has been fixed, I feel that we should drop these so we
> >don't have issues w/ name mismatches, such as introduced w/ gusc and sbc..
> 
> What are the benefits of this patch? Why should we commit it? What's  
> wrong with the current way of naming? How is this patch an improvement?
> 
> I don't object to the patch (haven't tested it), but what are the benefits?

The benifits are more consistant naming of our modules...  Only three
ethernet modules have if_ in front, and the rest are the raw device
names..  It also means that the module names matches more closely to
the driver that implemented by them (though this is a bit complicated
w/ the fact that pcm is the real driver behind these modules and pcm
isn't it's own device node)...  It also makes my driver/module dependancy
script do the correct thing wrt to gusc and sbc.. (The graph can be
seen at: http://people.FreeBSD.org/~jmg/driver.pdf )...  With out this
change gusc and sbc would be their own sub-graphs not connected to
anything besides their children...

Though I do realize that sound module names are special since they
can (and do) end in numbers which none of our other drivers do...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."


More information about the freebsd-arch mailing list