[PATCH RFC] Add a macro for null mount options to sbin/mount*

Tom Rhodes trhodes at FreeBSD.org
Wed Jun 1 08:32:26 PDT 2005


On Wed, 1 Jun 2005 21:23:23 +1000 (EST)
Bruce Evans <bde at zeta.org.au> wrote:

> On Wed, 1 Jun 2005, Xin LI wrote:

Here we go again!  :P

> 
> > In our mount* utilities, the null mount option, which is usually be used
> > as a terminator of an option vector, is defined with some hand-rolled
> > terms, e.g.: {NULL}, {NULL, 0, 0, 0}, etc.
> 
> "{ NULL }" is the documented way.  See getmntopts.3.

That manual page has been unhooked since it's import IIRC.

> 
> > I think it would be nice to have a new macro to deal with this, say,
> > MOPT_NULL, which would be extended to {NULL, 0, 0, 0}, which can act as
> > an explicit initialize.  And in my opinion, something like:
> >
> > %%%
> > opt = {
> > 	MOPT_STD,
> > 	MOPT_NULL
> > };
> > %%%
> 
> MOPT_NULL is a poor name.  It is not a null option, but a terminator that
> happens to have nulls in it.

But MOPT_END is a better name, I like it.  :)

-- 
Tom Rhodes


More information about the freebsd-arch mailing list