cvs commit: src/sys/dev/pci pci.c

[M. Warner Losh]

In message: <20041203194201.GB16093 at ns1.xcllnt.net>
            Marcel Moolenaar <marcel at xcllnt.net> writes:
: On Fri, Dec 03, 2004 at 11:05:20AM -0700, M. Warner Losh wrote:
: > In message: <200412030813.iB38DA12044595 at repoman.freebsd.org>
: >             Nate Lawson <njl at FreeBSD.org> writes:
: > : njl         2004-12-03 08:13:09 UTC
: > : 
: > :   FreeBSD src repository
: > : 
: > :   Modified files:
: > :     sys/dev/pci          pci.c 
: > :   Log:
: > :   Non-x86 platforms cannot use the ACPI includes.  This should be fixed but
: > :   for now, only include the headers for i386, amd64, or ia64.
: > :   
: > :   Pointed out by: grehan
: > 
: > We likely should have a sys/$MACHINE_ARCH/include/_config.h that has a
: > bunch of #defines that we can test instead of specific architecture
: > lists, don't you think?
: 
: A <machine/_config.h> doesn't give me warm fuzzies. Maybe we can
: rename <machine/pci_cfgreg.h> to <machine/pci.h> and give it some
: additional use (for this particular case of course).

There's a growing number of these sorts of things.  NetBSD has this
information in machine/types.h.  For example:

#include <mips/types.h>

#define __HAVE_GENERIC_SOFT_INTERRUPTS
#define __HAVE_DEVICE_REGISTER
#define __HAVE_NWSCONS

#define __HAVE_MIPS_MACHDEP_CACHE_CONFIG

I was thinking that we should start doing something similar...

Warner