no more WITNESS errors (was: stable kqueue locking up and running on SMP)

Brian Fundakowski Feldman green at
Wed Apr 21 11:43:11 PDT 2004

I know everyone's tired of seeing all the e-mail on the subject, so I'll 
keep it brief ;).  The kqueue fields that just happened to be stored in the
struct filedesc have always been owned by kqueue, and now they are locked
by kqueue, not filedesc, to become more semantically correct.  Just like all 
of the rest of the things (klist, knote, kqueue, fdp->fd_kn*), the lock 
right now is just a shared, global one, and should remain so unless 
profiling proves it unnecessary.

I would like to encourage more widespread testing.  The unused and 
nearly-unimplementable-EVFILT_PROC+NOTE_TRACK is gone, but the ability to 
nest kqueues remains (and will certainly impart difficulties if locking
is extended to separate the individual klists).  I don't think there are
any remaining issues for kqueue unless I've missed replacing some of the

"Final" patch, ripe for testing/MUTEX_PROFILING, at:

Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\

More information about the freebsd-arch mailing list