unbreaking alloca

Dag-Erling Smorgrav des at ofug.org
Sat Jun 14 08:27:07 PDT 2003

David's latest commit to cdefs.h breaks the build by causing lint to
fail for every source file that directly or indirectly includes
<sys/cdefs.h>; it will similarly cause non-GNU compilers to fail on
the same files.  This is entirely unnecessary as the patch was only
meant to add alloca(3) support on compilers that support it.

I'd like to commit the attached patch (after suitable testing of
course).  It removes all mention of alloca(3) from cdefs.h, and
instead modifies the declaration in stdlib.h so that GNU compilers see
alloca(sz) defined to __builtin_alloca(sz) while other compilers (and
linters) see a regular prototype.

I would also like to add (at some future date) a link-time warning for
alloca(3) similar to what we already have for gets(), mktemp() etc.

Dag-Erling Smorgrav - des at ofug.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: alloca.diff
Type: text/x-patch
Size: 1264 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20030614/2f256e29/alloca.bin

More information about the freebsd-arch mailing list