cvs commit: src/sys/dev/fxp if_fxp.c

[Matthew N. Dodd]

On Tue, 15 Apr 2003, M. Warner Losh wrote:
> foo |= BIT;
> if ((foo & BIT) == 0)
>    whine-and-fail;

Indeed.

> is that what you are saying?
>
> : This would keep drivers from having to check and see if PCIM_CMD_PORTEN or
> : PCIM_CMD_MEMEN is set.
>
> Yes.
>
> : This requires changing the definition of the 'enable_io' method.
> :
> : Since we're here we should change 'disable_io' and
> : '{enable,disable}_busmaster' as well.
>
> If we're going to do this, then we need to do it soon.

I'm working on patches.

-- 
| Matthew N. Dodd  | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD  |
| winter at jurai.net |       2 x '84 Volvo 245DL        | ix86,sparc,pmax |
| http://www.jurai.net/~winter |  For Great Justice!  | ISO8802.5 4ever |