#include <sys/lock.h> and <sys/mutex.h>

Poul-Henning Kamp phk at phk.freebsd.dk
Tue Apr 1 00:22:34 PST 2003


As we progress down the path of SMPng we will need to include
<sys/lock.h> and <sys/mutex.h> in more and more files.

The current score, not counting nested include cases, they currently
are included approx 16% and 19% of all .c files under /sys.

My present predicament is that I will probably put a mutex in the
bio queue which is defined in <sys/bio.h>, and so far, I've found
20 .c files where I need to add <sys/lock.h> and <sys/mutex.h> and
I am not yet at a point where LINT compiles.

Do we have a plan for these in the future ?  I can see three obvious
options:

A) define them leaf #includes, and #include them from the majority of
   our .c files.

B) Include them nested from other .h files which need them, in my
   case <sys/bio.h>

C) Include them nested from a central .h file like <sys/kernel.h>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


More information about the freebsd-arch mailing list