[Bug 209924] 11.0 -r301815 buildkernel via amd64-gcc fails for: .../dev/drm2/i915/dvo_ch7xxx.c related redundant declarations

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209924

--- Comment #10 from commit-hook at freebsd.org ---
A commit references this bug:

Author: ngie
Date: Wed Aug  3 00:03:03 UTC 2016
New revision: 303689
URL: https://svnweb.freebsd.org/changeset/base/303689

Log:
  MFC r302571,r302572,r302577,r302841:

  Approved by: re (gjb)

  r302571:

  Remove redundant declaration for radeon_pm_acpi_event_handler(..) to fix
  -Wredundant-decls warning

  PR:           209924
  Tested with:  devel/amd64-gcc (5.3.0)

  r302572:

  Remove redundant declarations for intel_fbc_enabled(..) and
  i915_gem_dump_object(..) to fix -Wredundant-decls warning

  PR:           209924
  Tested with:  devel/amd64-gcc (5.3.0)

  r302577:

  Add missing default case to capable(..) function definition

  By definition (enum __drm_capabilities), cases other than CAP_SYS_ADMIN
  aren't possible. Add in a KASSERT safety belt and return false in
  !INVARIANTS case if an invalid value is passed in, as it would be a
  programmer error.

  This fixes a -Wreturn-type error with gcc 5.3.0.

  r302841:

  Always panic if an invalid capability is passed to `capable(..)` instead of
  just with INVARIANTS

  rwatson's point was valid in the sense that if the data passed at runtime is
  invalid, it should always trip the invariant, not just in the debug case.
  This is a deterrent against malicious input, or input caused by hardware
  errors.

  Requested by: rwatson

Changes:
_U  stable/11/
  stable/11/sys/dev/drm2/drm_os_freebsd.h
  stable/11/sys/dev/drm2/i915/i915_drv.h
  stable/11/sys/dev/drm2/radeon/radeon_acpi.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.