[PATCH] Updated quirk-driven R3000Z patches

Coleman Kane zombyfork at gmail.com
Wed Feb 16 13:21:33 PST 2005


On Wed, 16 Feb 2005 10:36:28 -0800, David O'Brien <obrien at freebsd.org> wrote:
> [ PLEASE don't top-post, else I may not reply. This is a Unix list. ]
> 
> On Wed, Feb 16, 2005 at 02:08:08PM +0000, Coleman Kane wrote:
> > Yeah the recipient of the fix just emailed me about this, I am guessing
> > that the #if 0 is the uncommitable part. Is there any way that this can
> > be done by the kernel (the PCI reg write, that is)? Is there any reason
> > that it can't be done there?
> 
> Yes, the "#if 0" in
> http://lists.freebsd.org/mailman/htdig/freebsd-amd64/2005-January/003365.html
> isn't commitable.
> > > All you need is the second hunk, which is commitable, I believe.  The
> > > first hunk has to be fixed from BIOS or manually corrected by:
> 
> Jung-uk, can you post another patch with just this fix?  In a commitable
> form please.
> 
> --
> -- David  (obrien at FreeBSD.org)
> _______________________________________________
> freebsd-amd64 at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-amd64
> To unsubscribe, send any mail to "freebsd-amd64-unsubscribe at freebsd.org"
> 

I have attached the patch with the #if 0 / #endif removed. Can anyone
please enlighten me as to why the first hunk would be a 'regression'?

--
coleman


More information about the freebsd-amd64 mailing list