ftpd in debug mode crashes in vsyslog

[Joerg Micheel]

This might be a variation on the va_list_q problem discussed earlier,
but I am not sure.

I am runnning a dual Opteron 244 on Tyan 2882 with 4GB PC3200.

ftpd is started as ./ftpd -d -ll -S -A -D, or ./ftpd -d -ll -S -A
from inetd.conf.

If you connect from a client, you get the welcome prompt, as soon
as you provide your user name, the server dies. gdb log on ftpd.core
as below:

(gdb) where
#0  0x0000000000410f16 in __vfprintf (fp=0x200e94ea0, fmt0=0x4130d9 "%s FTP server (%s) ready.", ap=0x7fffffffe080)
    at /usr/src/lib/libc/stdio/vfprintf.c:1044
#1  0x000000000040fb7e in vfprintf (fp=0x200e94ea0, fmt0=0x4130d9 "%s FTP server (%s) ready.", ap=0x7fffffffe080)
    at /usr/src/lib/libc/stdio/vfprintf.c:403
#2  0x000000000040f494 in vsyslog (pri=95, fmt=0x4130d9 "%s FTP server (%s) ready.", ap=0x7fffffffe080)
    at /usr/src/lib/libc/gen/syslog.c:220
#3  0x00000000004085a2 in reply (n=220, fmt=0x4130d9 "%s FTP server (%s) ready.") at ftpd.c:2382
#4  0x00000000004054fe in main (argc=0, argv=0x7fffffffeb28, envp=0x7fffffffe0c0) at ftpd.c:626

If you leave out -d from the ftpd command line, reply() won't call
vsyslog, and subsequently the server runs stable. I have spent some
time looking into the problem and studying the code, but I can't find
anything obviously wrong.

Please Cc joerg at nlanr.net on reply, as I am not presently subscribed to
freebsd-amd64.

Thank you.
	Joerg