[PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs
jkim at FreeBSD.org
Tue Apr 19 21:42:18 UTC 2011
On Tuesday 19 April 2011 05:27 pm, Brandon Gooch wrote:
> On Tue, Apr 19, 2011 at 4:02 PM, Jung-uk Kim <jkim at freebsd.org>
> > On Tuesday 19 April 2011 04:55 pm, Brandon Gooch wrote:
> >> On Tue, Apr 19, 2011 at 3:24 PM, Jung-uk Kim <jkim at freebsd.org>
> > wrote:
> >> > On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote:
> >> >> Having chased boogiemen in this area before, I think this
> >> >> patch makes good sense even though it breaks the device model
> >> >> a little. However, the hardware in question really is special
> >> >> on x86...
> >> >>
> >> >> Warner
> >> >
> >> > Actually I was working on a similar patch and it should be
> >> > ready soon.
> >> >
> >> > Jung-uk Kim
> >> You have a willing (if not completely capable) tester here, so I
> >> always look forward to your patches.
> > :-)
> > http://people.freebsd.org/~jkim/syscons.diff
> > Also attached here.
> Cool, building now...
> I noticed you didn't grab the Giant lock, which shouldn't be needed
> since Ed's work, correct?
Actually the real reason is locking is completely missing in
syscons(4) since we abandoned spltty(). Grabbing Giant here makes no
difference because of that reason. :-(
> >> As the situation has greatly improved, I hesitate to even say
> >> this, but...I wish the USB stack could be made to be
> >> suspend/resume resilient. It's really the only problem child in
> >> my laptop. Fortunately, it's easy enough to build the USB stack
> >> as modules and unload/reload them.
> > I tried to do something about it but new USB stack is completely
> > out of my expertise, unfortunately. :-(
> > Jung-uk Kim
> I understand, and again, I know it seems like I always bring it up
> to you whenever I get the chance -- because I do. Sorry :|
That's okay, I'm used to it. ;-)
> I should bug someone else (Hans or Andrew Thompson), or maybe the
> PC-BSD guys might get interested in fixing this eventually -- after
> GEM, KMS, etc... ;)
More information about the freebsd-acpi